Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Optimize calls to a statically known function #1790

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vouillon
Copy link
Member

@vouillon vouillon commented Jan 7, 2025

When the function to be called is statically known, we can call it directly instead of loading the code pointer from the closure.

@vouillon vouillon added the wasm label Jan 7, 2025
| `Cps -> Lambda_lifting.f)
(match Config.target (), effects with
| `Wasm, _ | _, `Double_translation -> Fun.id
| `JavaScript, `Cps -> Lambda_lifting.f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix ?

@hhugo
Copy link
Member

hhugo commented Jan 16, 2025

Is this ready for review ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants