Fix 1559 #1561
Merged
Fix 1559 #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhugo
commented
Feb 5, 2024
|
@vouillon, do you have time to comment on the current approach ? |
|
I tested 3556f36 locally and it fixes the issue with the actual code as well as the example I posted. Thank you! Happy to test other revisions as well if there are other ideas for solving. |
hhugo
commented
Feb 9, 2024
|
I'd like to have a single pass to compute all free variables of closures. edit: this has been implemented |
|
@rickyvetter, I've pushed an alternative fix. |
vouillon
reviewed
Feb 12, 2024
Comment on lines
+227
to
+229
| List.iter params ~f:(fun x -> Code.Var.ISet.add bound x); | ||
| iter_block_bound_vars (fun x -> Code.Var.ISet.add bound x) block; | ||
| List.iter args ~f:using; |
There was a problem hiding this comment.
Shouldn't we move these two lines outside of function traverse?
List.iter params ~f:(fun x -> Code.Var.ISet.add bound x);
List.iter args ~f:using;
hhugo
pushed a commit
to hhugo/opam-repository
that referenced
this pull request
Feb 21, 2024
CHANGES: ## Features/Changes * Mics: fix support for OCaml 5.2 * Compiler: no longer rely on IIFE for scoping variable inside loops * Compiler: avoid parsing bytecode sections twice, jsoo counter part of ocaml#12599 * Lib: add ellipse to canvasRenderingContext2D (@FayCarsons, ocsigen/js_of_ocaml#1555) ## Bug fixes * Compiler: fix global dead code elimination in a toplevel context * Compiler: fix exit-loop-early optim in presence of closure (ocsigen/js_of_ocaml#1561) * Compiler: remove quadratic behavior in generate.ml (ocsigen/js_of_ocaml#1531, ocsigen/js_of_ocaml#1567)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #1559
Exiting a for loop too early might result in invalid scope for functions declared inside the for-loop.
A function declaration inside inside a block is scoped to that block (in strict mode) and won't be visible outside.
A quick fix is to simply disable the exit-loop-early optimization until one find a proper fix for it.