Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
# Conflicts: # src/context/run-job-context.tsx
giurgiur99
requested review from
alexcos20,
andreip136,
bogdanfazakas,
dnsi0,
mihaisc and
ndrpp
as code owners
# Conflicts: # src/contexts/P2PContext.tsx
ndrpp
reviewed
Apr 8, 2026
src/services/nodeService.ts
Outdated
| signMessage, | ||
| }); | ||
| return sendCommandToPeer(multiaddrsOrPeerId, { | ||
| return ProviderInstance.fetchConfig(toNodeUri(nodeUri), { |
Member
There was a problem hiding this comment.
shouldn't this be downloadNodeLogs function?
Contributor
Author
There was a problem hiding this comment.
fixed in last commit
dnsi0
reviewed
Apr 9, 2026
| throw new Error('Node not ready'); | ||
| } | ||
| return sendCommandToPeer(multiaddrsOrPeerId, command, protocol); | ||
| return ProviderInstance.fetchConfig(toNodeUri(nodeUri), command); |
Contributor
There was a problem hiding this comment.
Is this calling the correct method?
Contributor
Author
There was a problem hiding this comment.
It was used as a passthrough method since the right method needed a signer. I created a new one that uses a signed message, please check latest commit. thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #422
Changes proposed in this PR: