define markov sample size for percentiles and probabilities calculations #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@SorooshMani-NOAA Do you approve this PR? |
SorooshMani-NOAA
approved these changes
Mar 20, 2025
Collaborator
SorooshMani-NOAA
left a comment
SorooshMani-NOAA
left a comment
There was a problem hiding this comment.
@FariborzDaneshvar-NOAA I'm ok with this for short term/testing ... but if we decide to keep it a variable in our runs, it's better to add it to the yaml as input so that it is documented in the ensemble info file.
Collaborator
Author
|
Thanks! I agree for the long term solution. We might also need to add all post-proc args (i.e., validate or not, PCA threshold (default=0.999), ...) to workflow.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
markov_samplesvariable with default value of 2000.