fix(intelligence): keep fresh zero-importance memories searchable - #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
#1084 made search ranking multiply storage relevance by effective_retention. Fresh memories whose importance evaluator returned 0.0 were initialized with current_retention=0.0, which zeroed out otherwise relevant hybrid-search results. This caused main Regression Tests to fail in test_native_hybrid_search.py::TestNativeHybridSearch::test_tc005_hybrid_search_fusion_effect, where a Zhang San hit was demoted below an unrelated Wang Wu result.
Verification
Release Note
This should be merged before cutting the next release because latest main currently has a failing Regression Tests workflow.