Skip to content
This repository was archived by the owner on Nov 25, 2025. It is now read-only.
This repository was archived by the owner on Nov 25, 2025. It is now read-only.

[Enhancement]: Connection GC #54

Description

@IHEII

Enhancement

There are serval problems in rpc::Connection garbage collection now.

  1. Connection::cancel_requests() duplicated used
  2. Connection.active is useless
  3. Another way to close the ConnectionSender/Reader/Connection gracefully. The reason why we use shutdown() to close the connection is that we have to use send(closepoison_packet).await to close ConnectionSender. I guess the oneshot::channel or active mentioned before could help to close the ConnectionSender. If we don't send the packet in close() asynchrony, we could implement a common way to drop/close the connection synchrony.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions