This repository was archived by the owner on Nov 25, 2025. It is now read-only.
Fix odp 436 version incompatible - #177
Merged
Merged
Conversation
JackShi148
force-pushed
the
fix_436_odp_incomp
branch
from
November 10, 2025 04:16
5ff1ac4 to
3fa4966
Compare
JackShi148
force-pushed
the
fix_436_odp_incomp
branch
from
November 10, 2025 06:02
3fa4966 to
d23d221
Compare
WeiXinChan
reviewed
Nov 17, 2025
| return obVersion, odpVersion, nil | ||
| } | ||
| return 0, errors.New(fmt.Sprintf("parse version %s failed", serverVersion)) | ||
| return 0, 0, errors.New(fmt.Sprintf("parse version %s failed 5", serverVersion)) |
JackShi148
force-pushed
the
fix_436_odp_incomp
branch
from
November 17, 2025 08:30
182d8d6 to
7f22a08
Compare
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ODP 436 appends new String part after Oceanbase Version, which causes incompatibility of the current version matching.
Solution Description
Fix the version matching regex.