Use Ctrl+C to exit observer in cli mode. #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What problem were solved in this pull request?
Issue Number: close oceanbase#281
Problem: If start observer in cli mode, we cannot exit observer by Ctrl+C.
### What is changed and how it works?
在待输入命令时按下Ctrl+C后，注意到日志中有这样的记录：
"[2023-12-04 11:20:30.830780 pid:5338 tid:7fcf688ee7c0 ctx:0 WARN: my_readline@cli_communicator.cpp:71] >> failed to read line: Interrupted system call"
结合“cli_communicator.cpp:71”代码，可以知道此时系统错误被捕捉到且记录在errno中（此时errno为4）。
故当fgets读到空字符串时，若errno==4，可判定此时用户按下了Ctrl+C，这与用户输入“exit”等退出命令是等效的，故可看为用户输入了“interrupted"，借用“bool is_exit_command(const char *cmd)”函数判断用户输入的命令是否是退出命令，即可实现类似于用户输入了“exit”等命令的退出效果。
### Other information
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
- Coverage 24.36% 24.36% -0.01%
==========================================
Files 215 215
Lines 10632 10633 +1
==========================================
Hits 2591 2591
- Misses 8041 8042 +1 ☔ View full report in Codecov by Sentry. |
hnwyllmm
requested changes
Dec 4, 2023
hnwyllmm
reviewed
Dec 4, 2023
hnwyllmm
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem were solved in this pull request?
Issue Number: close #281
Problem: If start observer in cli mode, we cannot exit observer by Ctrl+C.
What is changed and how it works?
Other information