Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a lock to make LOG_HEAD thread-safe #{317} #327

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

Wenbin1002
Copy link
Contributor

What problem were solved in this pull request?

Issue Number: close #317

Problem:

What is changed and how it works?

Other information

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2023

CLA assistant check
All committers have signed the CLA.

deps/common/log/log.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@hnwyllmm hnwyllmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. But there are some problems should be resolved.

deps/common/log/log.h Outdated Show resolved Hide resolved
Helloworld-lbl and others added 2 commits December 1, 2023 06:39
### What problem were solved in this pull request?

Issue Number: close oceanbase#255

Problem: 将 https://ask.oceanbase.com/t/topic/35604437/8 中的内容写入到
how_to_build.md 的FAQ章节中

### What is changed and how it works?

### Other information
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c2c6d7) 24.36% compared to head (3ba2fb8) 24.36%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #327   +/-   ##
=======================================
  Coverage   24.36%   24.36%           
=======================================
  Files         215      215           
  Lines       10632    10632           
=======================================
  Hits         2591     2591           
  Misses       8041     8041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hnwyllmm
Copy link
Collaborator

hnwyllmm commented Dec 1, 2023

I edit your file directly by clang-format.
When I tried to create a pull request, an error occurs so I give up.

@Wenbin1002
Copy link
Contributor Author

I edit your file directly by clang-format. When I tried to create a pull request, an error occurs so I give up.

sry, my first time to contribute, I'll check next time.

@hnwyllmm
Copy link
Collaborator

hnwyllmm commented Dec 1, 2023

That's fine. Thanks for your contribution.

@hnwyllmm hnwyllmm merged commit f863d6e into oceanbase:main Dec 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] localtime is not thread-safe
4 participants