Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved books section in Learn #1515

Closed
wants to merge 5 commits into from
Closed

Conversation

Riddhima23
Copy link
Contributor

Issue Description

The Books section was disorganised with irregularities in alignment of text with pictures and spacing between rows.
Before:
No spacing between two rows leading to crowding of books:

1

The position of text is not in accordance with the pattern of rest of the page:

3

Image of the book overflowing leading to shift in the title of next book:

5

Image of the book not aligned with the text :

6

No wrapping of text in the paragraph:

7

Overall the Books section looked somewhat like this:

final_6075112b445d0500ad3bd6b1_157559.mp4

Fixes #1403

Changes Made

Added space between them to avoid overcrowding:

1-a

Changed the alignment of title of the book in accordance with the rest of the site:

3-a

Fixed the overflowing image of the book :

5-a

Added top-margin to align the image of the book with the text:

6-a

Increased bottom-margin to make the text aligned:

7-a

This is how the final Books section looks like:

final_607510bd42ef460069abda5a_45834.mp4
  • Please check if the PR fulfills these requirements
  • PR is descriptively titled and links the original issue above
  • Before/after screenshots (if this is a layout change)
  • Details of which platforms the change was tested on (if this is a browser-specific change)
  • Context for what motivated the change (if this is a change to some content)

@Riddhima23 Riddhima23 closed this Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organizing books.html page
1 participant