Skip to content

Changes in layout of icons and meetings in OCaml Community Page #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

Kanak1081
Copy link

In Community page, under the 'Ocaml around the web' section, I have arranged all the 9 icons in three different rows. They look pretty symmetrical now. Also they are equal in size.

Arranging the icons in three different rows and aligning them properly. Also their size is equal now.
making icons in(Ocaml around the web) of same size
@avsm
Copy link
Member

avsm commented Mar 14, 2021

Thanks for the contribution, @Kanak1081! I've pushed this change to the staging site at https://staging.ocaml.org/ so we can look at it against the live site.

@Kanak1081
Copy link
Author

Hey @avsm that's my pleasure to contribute :) . I can see that you have pushed the code in https://staging.ocaml.org/ and I saw that the code has some differences from the code that I have generated a Pull Request for. And so, the result is not as expected.
If, I am not wrong, the code that is pasted right now in https://staging.ocaml.org/ is a bit incorrect. Can you please check !

Arranged the meetings inside cards and updated them to the latest three.
Updated the OCaml meetings with latest three and styled them here from Line no. 5664 to 5690.
@Kanak1081
Copy link
Author

Hi @avsm. How are you doing :) ? I have added two more commits to the community page and changed the layouts for OCaml Meetings, updated them with latest three and styled them a bit. I would be more than happy to know your suggestions. Thanks !

@Kanak1081 Kanak1081 changed the title Made icons in(OCaml around the web)of same size Changes in layout of icons and meetings in OCaml Community Page Mar 17, 2021
@avsm
Copy link
Member

avsm commented Mar 30, 2021

Hi @Kanak1081 -- would you be able to post before/after screenshots of the page as you see it? I'm seeing this at https://staging.ocaml.org/community/ so there is some sort of rendering error:

image

@Kanak1081
Copy link
Author

Yes @avsm
Before :
Screenshot (703)

After :
Screenshot (701)

@avsm
Copy link
Member

avsm commented Mar 31, 2021

Thanks @Kanak1081 -- from your screenshots, it appears that your changes have also modified the layout of the "meetings" and "news" columns, as well as changing the icons in "OCaml Around the Web". Would you be able to localise the changes so that you only modify the icon layouts? The "meetings" and "news" columns should be as they were before.

@patricoferris
Copy link
Contributor

patricoferris commented Mar 31, 2021

Looking great @Kanak1081 -- agree with everything Anil said. Stylistically the columns should be fine for meetings, from the original issue #1270 I think we just want to keep the improved grid layout for the icons and the updated meeting data, the actual style for these columns can remain as is (EDIT: I mean as they are currently on ocaml.org).

If that doesn't make sense please let me know. Thanks again :))

@avsm avsm marked this pull request as draft April 1, 2021 11:01
@avsm
Copy link
Member

avsm commented Apr 1, 2021

Just converting this into a draft PR until the requested changes have been made (no rush!)

@Kanak1081 Kanak1081 closed this Apr 2, 2021
@Kanak1081
Copy link
Author

Hi, @avsm , as of now, I have closed the pull request as I can see that there are many Outreachy applicants who are willing to contribute for this issue. My PR was actually hindering their work a bit. Looking ahead for doing more contributions for OCaml .😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants