[new release] mirage (2 packages) (4.10.4)

[reynir]

The MirageOS library operating system

• Project page: https://github.com/mirage/mirage
• Documentation: https://mirage.github.io/mirage/

CHANGES:

• Refactor right_tcpip_library (Refactor right_tcpip_library mirage/mirage#1622 @reynir, review by @hannesm)
• Correctly compare package pins when merging (Correctly compare package pins when merging mirage/mirage#1623 @reynir, review by @hannesm)

[jmid]

Thanks!

There are runtest failures on 5.2-5.4 caused by small expect test output differences it seems:
https://opam.ci.ocaml.org/github/ocaml/opam-repository/commit/6f0fc6a951253ffe47c1572d3ded0aa67df3d990/variant/compilers,5.4,mirage.4.10.4,tests

#=== ERROR while compiling mirage.4.10.4 ======================================#
# context              2.5.0~beta1 | linux/x86_64 | ocaml-base-compiler.5.4.0 | pinned(https://github.com/mirage/mirage/releases/download/v4.10.4/mirage-4.10.4.tbz)
# path                 ~/.opam/5.4/.opam-switch/build/mirage.4.10.4
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune runtest -p mirage -j 71
# exit-code            1
# env-file             ~/.opam/log/mirage-7-83e5fc.env
# output-file          ~/.opam/log/mirage-7-83e5fc.out
### output ###
# (cd _build/default/test/mirage && ./test.exe)
# Testing `mirage'.
# This run has ID `PHMM5IIN'.
# 
#   [OK]          basic          0   pp.
# 
# Full test results in `~/.opam/5.4/.opam-switch/build/mirage.4.10.4/_build/default/test/mirage/_build/_tests/mirage'.
# Test Successful in 0.000s. 1 test run.
# (cd _build/default/test/functoria && ./test.exe)
# Testing `functoria'.
# This run has ID `WXOQX4PO'.
# 
#   [OK]          cli              0   read_full_eval.
#   [OK]          cli              1   configure.

[...]

#   [OK]          version          3   unmet comment.
# 
# Full test results in `~/.opam/5.4/.opam-switch/build/mirage.4.10.4/_build/default/test/functoria/_build/_tests/functoria'.
# Test Successful in 0.007s. 41 tests run.
# File "test/functoria/e2e/errors.t", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/test/functoria/e2e/errors.t _build/default/test/functoria/e2e/errors.t.corrected
# diff --git a/_build/default/test/functoria/e2e/errors.t b/_build/default/test/functoria/e2e/errors.t.corrected
# index 637ded6..7a1c9e0 100644
# --- a/_build/default/test/functoria/e2e/errors.t
# +++ b/_build/default/test/functoria/e2e/errors.t.corrected
# @@ -6,7 +6,7 @@ of a device's connect function:
#    $ dune build
#    File "errors/in_device.ml", line 6, characters 2-26:
#    Error: Unbound value Unikernel_make__4.start'
# -  Hint: Did you mean start?
# +  Hint:   Did you mean Unikernel_make__4.start?
#    [1]
#    $ ./test.exe clean -f errors/in_device.ml
#  
# @@ -24,7 +24,7 @@ Then, not enough:
#    $ ./test.exe configure -f errors/in_functor_not_enough.ml
#    test.exe: [WARNING] Skipping version check, since our_version ("1.0~test") fails to parse: only digits and . allowed in version
#    $ dune build
# -  File "errors/test/main.ml", line 34, characters 3-26:
# +  File "errors/test/main.ml", line 34, characters 3-20:
#    Error: The module Unikernel_make__4 is a functor, it cannot have any components
#    [1]
#    $ ./test.exe clean -f errors/in_functor_not_enough.ml

To keep the CI noise level down it would be nice to fix these...

[hannesm]

For the salsa-core CI error I opened a separate issue #28956

[jmid]

Thanks, LGTM!

I believe I've seen most of the remaining revdeps failures before 👍

[mseri]

Yes I don't think there is any new failure. Thanks!