fix conf-oniguruma depext on nixos #28921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmid
approved these changes
Nov 19, 2025
Member
jmid
left a comment
jmid
left a comment
There was a problem hiding this comment.
OK, thanks!
May I ask what value os-family is for the platform?
We should update the table in the wiki with a nixos line (or someone with edit permission should, hint, hint):
https://github.com/ocaml/opam-repository/wiki/Depexts-os-distribution---os-family-values
While we are at it, we should add an os column to the top table.
Contributor
Author
No problem!
It's also |
Member
|
OK, thanks. I've just opened #28930 to keep track. This should be good to go! |
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm afraid I made a mistake in #26866 --
osis "linux" on NixOS, we should useos-distributioninstead.