-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[MLCUDDIDL] supports 5.0 by removing modules #28849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you submit the patch to the https://github.com/ocaml/opam-source-archives repository and link it from there? |
|
If it is okay with you I will keep the patch here until I'm able to make the CI turn green. (Or perhaps I can run it locally?) |
|
Sure! |
Hi @bobot, for some reason I stopped receiving notifications for my repositories on framagit. My apologies for not answering. I guess it's ok to strip When I find the time I'll comment more on the issue you linked. Or, most likely a discussion with some decision-makers at OCamlPro may help me find some time to do some support for the old packages I maintain(ed) ;) |
|
Oh @nberth, broken notification I understand well. Just a new major version could be enough for such breaking change. I think we need some help from the runtime for safely putting ML values in custom block, so I don't see any hope to support the other modules before long. |
|
Well, I'd indeed need to refresh myself on what changed w.r.t custom blocks since a few OCaml releases. And to answer one of your questions in the issue: that code was initially written for OCaml 3.12 or even earlier (I think), so |
only for < 5.0 since the module is removed for >= 5
a71973e to
330f52d
Compare
|
The MR is updated and an MR is created in opam-source-archives ocaml/opam-source-archives#54 |
|
All green now, thanks |
Mlcuddidl is a binding for cudd (BDD) which added some interesting functionalities in the C code. It went as far as letting the user put OCaml values as leaf of a BDD, so inside a C datastructure. This require some expert (god?) level collaboration with the runtime. The massive change of the runtime for ocaml 5.0 makes those juggling even more complicated.
This PR removes, only for OCaml >= 5.0, the problematic modules, so that the users can still use the usual BDD datastructure.
I'm not the maintainer which is @nberth , but he seems to be busy: https://framagit.org/nberth/mlcuddidl/-/issues/2