-
Notifications
You must be signed in to change notification settings - Fork 36
The ok_ko test takes an unreasonable amount of RAM #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi. How to know how much RAM is used by a process? |
|
Hi. I cannot reproduce your problem. On my machine, dune runtest takes 13s and about 2 Gb only. What are the characteristics of your machine? |
2GB sounds already pretty high for a single test case registered in opam-repository in my opinion. I'm running the command above in a docker container ( |
Anyway, you are right: we do not need to run the tests on opam anyway. It's useful for CI only. We are going to remove them. |
To this end, is it enough to remove the line " "@runtest" {with-test}" in lambdapi.opam? Should I update all the opam files in https://github.com/ocaml/opam as well? |
@fblanqui , I think it is good that you keep some tests in the opam part of the package, under the runtest alias. This means you can keep the standard opam layout and you can still benefit from the very nice opam CI infrastructure. What I'd suggest is you define a new alias: |
@ejgallego Thanks for your remark. Tests are run in the Lambdapi CI. So there is no need to add them on Opam again. Actually, in previous versions of Lambdapi, opam files did not include any tests. I don't remember why this has been included in the last release. |
Tests in opam are useful though. It allows to the opam-repo-ci to see breakages in dependencies of lambdapi more consistently |
Hello! I'm chiming in here as part of reviewing ocaml/opam-repository#27728 -- I'd like to echo @kit-ty-kate with a bit more detail on the advantages of running some core tests on the opam repository:
This benefits not only help Lambdapi in particular, but also have accumulative effects to ensure a stable and harmonious ecosystem of packages. If you are willing to reconsider, I can lend a hand to help factor out the less expensive tests into something that can be run during installation. |
Hi. Thank you for your detailed explanations. We'll try to add back some small tests later. |
Indeed thanks folks for the detailed explanations, I was wondering if there is already documentation explaining this to package authors? If that's not the case, I'd be happy to try to add a synthesis of the discussion for future reference, similar questions come often for example in Rocq. |
@ejgallego great question 😅 . I've created ocaml/opam-repository#27796 to discuss the point! Help on this would indeed be most welcome. |
Thanks for your remarks. I propose to close this issue as it is solved in ocaml/opam-repository#27728 and #1234 . |
The test located in
tests/ok_ko.ml
takes >8GB alone on my machine.If this amount of RAM is necessary, maybe it would be worth splitting into its own test disabled by default so that the various CI systems running on opam-repository do not run into this problem.
To reproduce: run
opam install -j1 -t lambdapi.2.6.0
and survey the RAM usage of the soon to spawnok_ko.exe
process.lambdapi: 2.6.0
OCaml: 4.14.2
Platform: Linux/x86_64
The text was updated successfully, but these errors were encountered: