lambdapi 2.6.0: do not run tests #27728
Conversation
There was a problem hiding this comment.
Thank you for your care in helping the repository with its CI load!
I have contributed to the discussion in Deducteam/lambdapi#1229 (comment) echoing the appeal to continue running tests on install.
| @@ -47,8 +47,6 @@ build: [ | |||
| "-j" | |||
| jobs | |||
| "@install" | |||
| "@runtest" {with-test} | |||
| "@doc" {with-doc} | |||
There was a problem hiding this comment.
I believe this will prevent documentation from being generated for users who request it during installation. This could impact users who view documentation locally and I suspect it will prevent the generation of the documentation at https://ocaml.org/p/lambdapi/latest/doc/index.html -- Is this intended?
|
Hi. I put back the doc target. But I cannot put back the test now as it would require to change the sources of the release. I'll perhaps add back some tests again later in the next release. |
|
Right, that would require a new release. I guess it is probably OK to skip these tests to reduce the load on the CI system, with the expectation that we'll have the tests added back in future releases, but with the most expensive tests removed. Thanks! |
Fix Deducteam/lambdapi#1229