Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(lsp): batch updates with cursor #998

Closed
wants to merge 1 commit into from
Closed

refactor(lsp): batch updates with cursor #998

wants to merge 1 commit into from

Conversation

rgrinberg
Copy link
Member

@rgrinberg rgrinberg commented Jan 5, 2023 •
edited
Loading

  • bring back encoding
  • stop recomputing line positions

@rgrinberg rgrinberg requested a review from ulugbekna January 5, 2023 00:04
@ulugbekna
Copy link
Collaborator

There seems to be bugs with this implementation

  1. I see much more phantom errors reported by merlin - same problem as in olsp can keep incorrect document src in its state because of encoding issues #934 I believe
  2. I experience this:

inserting a new line and saving causes repetition of a substring:

Screen.Recording.2023-01-08.at.04.54.47.mov

@rgrinberg
Copy link
Member Author

Yup. It's still wip. I'll push an updated version shortly

@rgrinberg
Copy link
Member Author

Replaced by #1004

@rgrinberg rgrinberg closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulugbekna ulugbekna Awaiting requested review from ulugbekna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgrinberg @ulugbekna