Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of high surrogate in UTF-16 #47

Merged
merged 5 commits into from
Oct 25, 2017

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Oct 21, 2017

Found while torturing AppVeyor by compiling OCaml in a directory called 🐫

@dra27
Copy link
Member Author

dra27 commented Oct 21, 2017

I'll review #46 tomorrow so that that could be included too, but I think there should be a release pre-4.06.0 containing this fix (it'd be hard to attack, but it feels wrong for OCaml to depend on a program with a faulty Unicode conversion)

@nojb
Copy link
Collaborator

nojb commented Oct 21, 2017

Unrelated to this PR of course, but the UTF-16 encoding could be done with Buffer. add_utf_16le_uchar from 4.06 onwards and we could add the present code to the Compat module.

@dra27
Copy link
Member Author

dra27 commented Oct 21, 2017

Actually, that's a much better idea - I'll add that to tomorrow's train-list!

@dra27
Copy link
Member Author

dra27 commented Oct 22, 2017

And three more commits to do that:

  • I found on my local AppVeyor an issue with the compiler updater (flexdll bootstrap didn't used to work if you had flexlink in PATH with no flexdll.h). I can separate that, but I don't expect you're worried about that being here!
  • A "slower" version of Buffer.add_utf_16le_uchar is added to the compatibility layer for pre-4.06.0 builds
  • A very simple Uchar module is added to the compatibility layer for pre-4.03.0 builds (I haven't actually tested that, but I think from inspection that should be OK)

@alainfrisch
Copy link
Collaborator

@dra27 Do you want to give a look at #46, or do you prefer me to create a release now?

@dra27
Copy link
Member Author

dra27 commented Oct 25, 2017

Sorry - I had, but I see that I was clearly expecting you to know my thoughts psychically! I'll go and commit them now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants