-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix encoding of high surrogate in UTF-16 #47
Conversation
I'll review #46 tomorrow so that that could be included too, but I think there should be a release pre-4.06.0 containing this fix (it'd be hard to attack, but it feels wrong for OCaml to depend on a program with a faulty Unicode conversion) |
Unrelated to this PR of course, but the UTF-16 encoding could be done with |
Actually, that's a much better idea - I'll add that to tomorrow's train-list! |
And three more commits to do that:
|
Sorry - I had, but I see that I was clearly expecting you to know my thoughts psychically! I'll go and commit them now... |
Found while torturing AppVeyor by compiling OCaml in a directory called 🐫