Use Make Automatic Variables, update msvs-detect #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
makefile-msvs-detect
branch
from
97c703c to
89ce2b6
Compare
MisterDA
force-pushed
the
makefile-msvs-detect
branch
from
89ce2b6 to
543ec4e
Compare
MisterDA
changed the title
CFLAGS and CPPFLAGS, update msvs-detect
MisterDA
force-pushed
the
makefile-msvs-detect
branch
3 times, most recently
from
9653ba2 to
aefb885
Compare
MisterDA
force-pushed
the
makefile-msvs-detect
branch
3 times, most recently
from
d952ca9 to
305b944
Compare
dra27
reviewed
Jan 17, 2024
There was a problem hiding this comment.
In-passing comment on one of the Makefile changes!
I've looked at some of the earlier commits of this already - I like the direction it's going, but could you split the first 3 commits to a separate PR because I think they should all pass immediately and it will get the noise out of the way of looking at the C compiler warnings part?
MisterDA
force-pushed
the
makefile-msvs-detect
branch
from
305b944 to
7f54e3c
Compare
MisterDA
changed the title
|
I've removed the compiler warnings commits from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hacking in passing, I decided to use Make Automatic Variables to avoid redundancies with file names, and update msvc-detect.