Skip to content

Conversation

@Leonidas-from-XIV
Copy link
Collaborator

This moves things around in the test a bit:

  • Fake extractor binaries are in a separate folder, so they don't need to be written multiple times if used in multiple tests
  • show_path shows the environment before execution to make it easier to see what's in PATH
  • Use (PATH=.fakebin …) consistently
  • Remove unzip --version, it's never called
  • Add a test for when there's just unzip and dune can't fall back to bsdtar.

@Leonidas-from-XIV Leonidas-from-XIV force-pushed the zip-extract-test-improvements branch from 17dfcdc to 338c90e Compare November 20, 2025 10:31
Copy link
Collaborator

@Sudha247 Sudha247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for cleaning up the test.

@Leonidas-from-XIV Leonidas-from-XIV merged commit 172ebb1 into ocaml:main Nov 20, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants