Add dune-find-dominating command to dune.el
#12696
Open
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arvidj
force-pushed
the
aj/dune.el-find-dominating
branch
from
1305060 to
c80cf43
Compare
shonfeder
approved these changes
Nov 13, 2025
Member
shonfeder
left a comment
shonfeder
left a comment
There was a problem hiding this comment.
Thanks for the contribution, @arvidj !
This seems useful to me, and I have tested it locally to confirm it works as intended.
I have one suggestion, which I think helps with readability of the function. If you don't have any objection, please make that change and mark this as ready for review, and we can merge it in!
arvidj
force-pushed
the
aj/dune.el-find-dominating
branch
from
2788b2b to
12f8033
Compare
Signed-off-by: Arvid Jakobsson <[email protected]>
arvidj
force-pushed
the
aj/dune.el-find-dominating
branch
from
12f8033 to
3bf68a6
Compare
Author
|
Thanks for your review @shonfeder. I've pushed a version amended with your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a command
dune-find-dominatingtodune.el. It finds the dominatingdunefile, and allows you to jump back usingxref-go-back.