Move dev-tool lock dirs into hidden folder #12671
Conversation
|
You can interpret the statement "move dev-tool lock dirs into hidden folder" in two different ways. Either that the When we discussed this I initially meant the latter case. Doing something like slotting it in _build/ seems sensible. All the issues we have with people complaining about the folder currently will not go away when we make the directory hidden IMO. |
This makes sens to me too! |
|
I'm out of the conversation, but I wonder if dev-tools folder could be inside dune.lock folder? |
|
The issue we have here is that we don't want people committing their developer tool lock files but we don't mind people committing the build locks. If we merge them, then we cause problems for both parties. |
|
Right, I figure it out but maybe up to them? If it's the only issue, can place a .gitignore inside dune-lock? Place it under _build means that any |
It would not, as then Dune will recreate the build plan for dev-tools if it does not exist. This is what it is doing at the moment already if you delete your |
Leonidas-from-XIV
force-pushed
the
dev-tool-dotfiles
branch
4 times, most recently
from
7a2d49f to
4c44f66
Compare
Leonidas-from-XIV
requested review from
Alizter,
ElectreAAS,
Sudha247 and
punchagan
Leonidas-from-XIV
force-pushed
the
dev-tool-dotfiles
branch
2 times, most recently
from
57e78aa to
8cc6508
Compare
Leonidas-from-XIV
force-pushed
the
dev-tool-dotfiles
branch
from
8cc6508 to
0e622f0
Compare
|
I believe this is read for another round of reviews :) |
src/dune_rules/utop.ml
Outdated
| Fs_memo.dir_exists (In_source_dir path)) | ||
| lazy | ||
| (let path = Lock_dir.dev_tool_untracked_lock_dir Utop in | ||
| Path.Untracked.exists path) |
There was a problem hiding this comment.
How would this work in watch mode without Fs_memo?
There was a problem hiding this comment.
It won't, but that wasn't the goal here. Fs_memo requires Path.Outside_build_dir which is going to have to be expanded if we are to account for _build/something-that's-not-a-context.
Leonidas-from-XIV
force-pushed
the
dev-tool-dotfiles
branch
2 times, most recently
from
7a26281 to
9e80516
Compare
test/blackbox-tests/test-cases/pkg/ocamlformat/ocamlformat-dev-tool-fails-to-build.t
Outdated
Show resolved
Hide resolved
Alizter
requested review from
Alizter and
rgrinberg
and removed request for
ElectreAAS
src/dune_rules/format_rules.ml
Outdated
| Source_tree.find_dir path >>| Option.is_some | ||
| Lock_dir.dev_tool_external_lock_dir Ocamlformat | ||
| |> Path.external_ | ||
| |> Path.Untracked.exists |
There was a problem hiding this comment.
Any reason why we're still breaking watch mode here? It's not really required to keep it working, but don't see why it's needed to intentionally break it here.
There was a problem hiding this comment.
The issue here is that when I change this to use Fs_memo.dir_exists (Path.Outside_build_dir.External (Lock_dir.dev_tool_external_lock_dir Ocamlformat)) I get a cached value of false, whereas Path.Untracked.exists returns true.
I've changed this to use the DUNE_CONFIG__LOCK_DEV_TOOL flag as signal for whether the lock dir was created instead of querying the file system (/cache). Given that this functionality is only enabled when the flag is set it seems to work and pass all the tests.
Leonidas-from-XIV
force-pushed
the
dev-tool-dotfiles
branch
from
d767790 to
cc67c4b
Compare
Leonidas-from-XIV
force-pushed
the
dev-tool-dotfiles
branch
from
cc67c4b to
b1f77f1
Compare
|
I am still reviewing so I will reach a conclusion tomorrow. |
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Signed-off-by: Ali Caglayan <[email protected]>
Signed-off-by: Marek Kubica <[email protected]>
Alizter
force-pushed
the
dev-tool-dotfiles
branch
from
b1f77f1 to
3a3bd40
Compare
5 participants
This follows the discussion from the 29th of October where we decided that the dev-tools can (for now) live in a directory that is unlikely to be committed to git.
closes #12097