Skip to content

Conversation

Leonidas-from-XIV
Copy link
Collaborator

This is pulling out a change from #12394 to make it easier to control whether package management should be force-enabled, force-disabled or left at the default setting.

@Leonidas-from-XIV Leonidas-from-XIV changed the title tests: Enable package management by default and add helpers tests: Enable package management by default in test and add helpers to disable it Sep 22, 2025
@Alizter
Copy link
Collaborator

Alizter commented Sep 22, 2025

I'm not certain about this. Doesn't this mean we stop testing the default setting?

@Leonidas-from-XIV
Copy link
Collaborator Author

The default setting is still tested with unset_pkg.

Copy link
Collaborator

@ElectreAAS ElectreAAS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

This is pulling out a change from ocaml#12394 to make it easier to control
whether package management should be force-enabled, force-disabled or
left at the default setting.

Signed-off-by: Marek Kubica <[email protected]>
@Leonidas-from-XIV Leonidas-from-XIV merged commit 751b118 into ocaml:main Sep 24, 2025
24 of 26 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the pkg-enable-disable-helper branch September 24, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants