Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanups in the opam solver #11439

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

rgrinberg
Copy link
Member

  • Use |> to improve readability along with labels
  • Use Package_version.dev for the version

@rgrinberg rgrinberg force-pushed the ps/rr/refactor__cleanups_in_the_opam_solver branch from 2e94349 to 937422c Compare February 4, 2025 00:35
@maiste maiste added refactoring solver Related to the internal solver labels Feb 4, 2025
Copy link
Collaborator

@maiste maiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some nitpicky questions.

src/dune_pkg/opam_solver.ml Outdated Show resolved Hide resolved
src/dune_pkg/opam_solver.ml Show resolved Hide resolved
src/dune_pkg/opam_solver.ml Outdated Show resolved Hide resolved
* Use |> to improve readability along with labels
* Use `Package_version.dev` for the version

Signed-off-by: Rudi Grinberg <[email protected]>

<!-- ps-id: 4592372f-f66f-49a5-b481-dd4188836ef5 -->

Signed-off-by: Rudi Grinberg <[email protected]>
@rgrinberg rgrinberg force-pushed the ps/rr/refactor__cleanups_in_the_opam_solver branch from 937422c to e04dbf7 Compare February 4, 2025 22:46
@rgrinberg rgrinberg merged commit d50209c into main Feb 5, 2025
13 of 27 checks passed
@rgrinberg rgrinberg deleted the ps/rr/refactor__cleanups_in_the_opam_solver branch February 5, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring solver Related to the internal solver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants