Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrent fiber solver #11362

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Concurrent fiber solver #11362

merged 3 commits into from
Feb 4, 2025

Conversation

rgrinberg
Copy link
Member

@rgrinberg rgrinberg commented Jan 19, 2025

Switch to parallel iteration from sequential iteration. This required switching to a fiber aware cache.

This gives a small but nice boost:

Before:

Benchmark 1: ~/github/ocaml/dune/_build/default/bin/main.exe pkg lock
  Time (mean ± σ):      1.962 s ±  0.069 s    [User: 1.285 s, System: 0.444 s]
  Range (min … max):    1.882 s …  2.086 s    10 runs

After:

Benchmark 1: ~/github/ocaml/dune/_build/default/bin/main.exe pkg lock
  Time (mean ± σ):      1.752 s ±  0.315 s    [User: 1.284 s, System: 0.464 s]
  Range (min … max):    1.535 s …  2.606 s    10 runs

@maiste maiste added the solver Related to the internal solver label Jan 28, 2025
@rgrinberg
Copy link
Member Author

ping @gridbugs or @Leonidas-from-XIV

Copy link
Collaborator

@gridbugs gridbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing this.

Signed-off-by: Rudi Grinberg <[email protected]>

<!-- ps-id: 07ae56df-ed69-43e6-8e4e-036afc7ceba8 -->

Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>

<!-- ps-id: 5d1f0759-3b54-4277-a80a-8d3855264729 -->

Signed-off-by: Rudi Grinberg <[email protected]>
Signed-off-by: Rudi Grinberg <[email protected]>

<!-- ps-id: 28bc84bb-3481-43e8-ac8c-0737cb2bcc43 -->

Signed-off-by: Rudi Grinberg <[email protected]>
@rgrinberg rgrinberg force-pushed the concurrent-fiber-solver branch from 37534cf to 7b9c153 Compare February 3, 2025 19:23
@rgrinberg rgrinberg merged commit f493a87 into main Feb 4, 2025
20 of 27 checks passed
@rgrinberg rgrinberg deleted the concurrent-fiber-solver branch February 4, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solver Related to the internal solver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants