Update promotion.rst to explain mode promote

[chris-armstrong]

Explain the difference between diffing and promotion and the use of (mode promote)

[chris-armstrong]

I've tried to fix the broken link, but not sure if that'll take

[Leonidas-from-XIV]

Thanks for the changes! I've added a few notes on how to improve the wording and accuracy a little bit.

I've also ran CI and you can see that the link does in fact work: https://dune--11122.org.readthedocs.build/en/11122/concepts/promotion.html

[chris-armstrong]

Thanks @Leonidas-from-XIV. Please see my changes above, hopefully these adequately address your comments.

[Leonidas-from-XIV]

Thanks, I've added a few corrections but it's on the right way.

@christinerose can you please take a look at the text and check?

[christinerose]

Thanks, I've added a few corrections but it's on the right way.

@christinerose can you please take a look at the text and check?

I made a few minor grammatical changes and suggested a couple of sentence alteration for readability. See what you think!

[maiste]

@chris-armstrong I have rebased the PR. Could you address the remaining comments? I think this PR is almost ready to be merged.

[chris-armstrong]

Could you please take another look @maiste, hopefully this is ready to go

[maiste]

Thanks for your reactivity! Two small suggestions, but otherwise it looks good to me 👍
@Leonidas-from-XIV could you take another look at it when you have time to?

[Leonidas-from-XIV]

Looks good but is failing the DCO check. @chris-armstrong can you sign off your commits?

[chris-armstrong]

I don't know how to do what you're asking.

Can we just close this PR - this was meant to be a small improvement to the documentation to make it clearer, but it's been back and forth several times over a few months that it seems hardly worth bothering with now.

[chris-armstrong]

I'm happy to waive copyright on the changes in this PR if it makes it easier

[Leonidas-from-XIV]

When accepting contributions we require the contributors to sign off that they possess the right to contribute the code etc. See more about it here.

This is achieved via the

In your case the easiest way via the Signed-off-by: Your Name <[email protected]> line in the git commit message, like in my commit.

The easiest way to add a signature to existing commits is to

$ git rebase main --signoff
$ git push --force

(This is also what I do when I forget to sign off my commits)

[maiste]

Thanks @chris-armstrong for the contribution! 🙏