QCheck.0.90 migration #578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QCheck.0.90 release revises the API, deprecating a number of previous bindings:
https://github.com/c-cube/qcheck/releases/tag/v0.90
With the help of https://github.com/v-gb/ocamlmig and the forthcoming annotations from c-cube/qcheck#398, I've been able to migrate to the new API without much effort.
In a subsequent pass, I then reviewed the changes:
Lin.int_smallwould be translated to usenat_small(for a distribution-preserving mapping) which excludes negative numbers, and therefore changed it to instead use the newint_smallincluding negative numbers. In effect this creates an API change of behavior.array_small.Let's see if the changes causes the CI test suite to behave any different...