compatibility with lwt.6#31
Open
raphael-proust wants to merge 3 commits intoocaml-multicore:masterfrom
Open
Conversation
Collaborator
|
CI lower bounds check failed with this (probably just needs a lower-bound added): With Lwt 6, the tests need updating due to a change in the output ordering (assuming that's expected): --- a/_build/default/test/test.md
+++ b/_build/default/test/.mdx/test.md.corrected
@@ -41,20 +41,20 @@ Lwt and Eio fibers don't block each other:
);;
+eio: i = 1
+ lwt: i = 1
-+ lwt: i = 2
+eio: i = 2
-+ lwt: i = 3
++ lwt: i = 2 |
Author
|
will make the changes (and check the tests), thanks |
Author
|
made the changes i don't know why the tests change, i'll try to read the lwt_eio internal to understand what's the synchronisation mechanism there |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.