refactor: remove Format constructor #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
ps/branch/refactor__remove_format_constructor
branch
from
6f268ce to
b400de5
Compare
We remove the Format constructor in Pp.t that prevented it from being drectly serializable. Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
ps/branch/refactor__remove_format_constructor
branch
from
b400de5 to
5dd34c5
Compare
Closed
mbarbin
added a commit
to mbarbin/opam-repository-1
that referenced
this pull request
Sep 16, 2024
CHANGES: - Prepare release (ocaml-dune/pp#21, @mbarbin) - Upgrade to `ocamlformat.0.26.2`. - Fmt the code - Add CI badge to README - Upgrade GitHub workflow actions dependencies (checkout@v4, setup-ocaml@v3) - Add more validation steps in CI - Add `ocamlformat` as dev-setup dependency - Add `Pp.verbatimf`. (ocaml-dune/pp#18, @mbarbin) - Add `Pp.paragraph` and `Pp.paragraphf` (ocaml-dune/pp#19, @Alizter) - Remove `of_fmt` constructor. (ocaml-dune/pp#17, @Alizter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the Format constructor in Pp.t that prevented it from being directly serializable.