chore: consistent maming of type vars and add missing comments #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We make the naming of type variables consistent by using 'tag to emphasize we are talking about the type of tags. We also add documentation to functions in the API that were missing it. Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
ps/branch/chore__consistent_maming_of_type_vars_and_add_missing_comments
branch
from
e494ac6 to
6037e9a
Compare
Alizter
commented
Oct 17, 2023
|
|
||
| (** Same as [text] but take a format string as argument. *) | ||
| val textf : ('a, unit, string, _ t) format4 -> 'a | ||
| val textf : ('a, unit, string, 'tag t) format4 -> 'a |
There was a problem hiding this comment.
Turns out the type of this is correct and it should not return a 'a t.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make the naming of type variables consistent by using 'tag to emphasize we are talking about the type of tags. We also add documentation to functions in the API that were missing it.