Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automatically fill the id attributes of the headings #267
automatically fill the id attributes of the headings #267
Changes from 17 commits
5727396
a25466b
1a32e7b
2e52f7c
a0ce723
0ed7b79
ad0b2a9
36c6f9a
1fb9404
ff3b1c8
c07e958
02c6fe8
8f4a3fb
f5cab78
4cdac96
f2ffab2
820f310
2096643
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can have the
block
function take a record for this argument that can carry some configuration/state? For the identifier numerical suffix, it could be aint StringMap.t
. Of course, we could also use a mutable hash map for this, but would be nice to avoid if feasible. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, I added an
int StringMap.t
to keep track of the numerical suffix. Let me know what you think :)