Remove direct aws sdk dependencies #438
Merged
+2
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest not adding AWS SDK dependencies directly, but depend on those that come from
pure-xxx-tagless
. The reason behind is the fact, that mostly this ispure-xxx-tagless
which uses that SDK directly. Bumping that AWS SDK version on our own inpass4s
can lead to unpredictable behaviour, like runtime errors because of backward incompatible AWS SDK changes.For example in 2.21.7 there was a breaking change in AWS SDK - a QueryParametersToBodyInterceptor was moved to another package aws/aws-sdk-java-v2@04dffd7. In case of
pure-xxx-tagless
dependends on 2.20.x andpass4s
on 2.21.7 then we would have runtime errors.