Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct aws sdk dependencies #438

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

matwojcik
Copy link
Collaborator

I suggest not adding AWS SDK dependencies directly, but depend on those that come from pure-xxx-tagless. The reason behind is the fact, that mostly this is pure-xxx-tagless which uses that SDK directly. Bumping that AWS SDK version on our own in pass4s can lead to unpredictable behaviour, like runtime errors because of backward incompatible AWS SDK changes.

For example in 2.21.7 there was a breaking change in AWS SDK - a QueryParametersToBodyInterceptor was moved to another package aws/aws-sdk-java-v2@04dffd7. In case of pure-xxx-tagless dependends on 2.20.x and pass4s on 2.21.7 then we would have runtime errors.

@bwiercinski
Copy link
Collaborator

aren't unit and integration tests which are implemented in this project sufficient to check that the class is missing? i think this kind of failures can be detected by the simplest smoke tests

@bwiercinski
Copy link
Collaborator

these overrides were added because pure-xxx-tagless doesn't have often an update. and often aws skd have some vulnerabilities found. of course a client of the pass4s can override the aws sdk by himself/herself, but then he wouldn't run the mentioned tests which are implemented in pass4s project

@matwojcik
Copy link
Collaborator Author

these overrides were added because pure-xxx-tagless doesn't have often an update. and often aws skd have some vulnerabilities found. of course a client of the pass4s can override the aws sdk by himself/herself, but then he wouldn't run the mentioned tests which are implemented in pass4s project

Exactly this is the case. Apart from that, it can happen that not all the paths are covered in the tests, and main user of the SDK (so tagless lib) breaks then.

@matwojcik
Copy link
Collaborator Author

I've asked for release laserdisc-io/fs2-aws#1122, however the previous ones were not that far away, so hopefully that should not be that problematic in the future.

@matwojcik matwojcik merged commit 61097e1 into main Nov 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants