Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: YouTube Video Summarizer #5062

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

mbramani
Copy link

@mbramani mbramani commented Jan 4, 2025

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/mbramani/obsidian-yt-video-summarizer

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

github-actions bot commented Jan 4, 2025

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't use the word obsidian in the plugin ID. The ID is used for your plugin's folder so keeping it short and simple avoids clutter and helps with sorting.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add Plugin: YT Video Summarizer Add plugin: YouTube Video Summarizer Jan 4, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3][4][5][6][7][8][9]:You should avoid assigning styles via JavaScript or in HTML and instead move all these styles into CSS so that they are more easily adaptable by themes and snippets.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jan 5, 2025
@mbramani
Copy link
Author

mbramani commented Jan 5, 2025

Thank you for the feedback. I have addressed the styling issues by:

  1. Moving all inline styles to a dedicated styles.css file
  2. Implementing BEM methodology for CSS classes
  3. Using Obsidian's CSS variables for theme compatibility
  4. Removing all JavaScript-based styling

The changes can be seen in commit: refactor(styles): migrate modals to use CSS classes

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jan 5, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 5, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@Zachatoo Zachatoo self-assigned this Jan 15, 2025
@Zachatoo Zachatoo added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Jan 15, 2025
@mbramani
Copy link
Author

mbramani commented Jan 15, 2025

Thank you @Zachatoo for the detailed review! I've addressed all the issues in this commit:

  1. Updated command callbacks to use proper editor interface
  2. Removed debug logging statements
  3. Fixed UI text to use sentence case

Changes can be reviewed in the commit diff. Let me know if anything needs further adjustment!

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Your manifest does not have the required version property.
❌ Your latest version number is not valid. Only numbers and dots are allowed.
❌ Unable to find a release with the tag undefined. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@mbramani
Copy link
Author

fixed

  • Your manifest does not have the required version property.
  • Your latest version number is not valid. Only numbers and dots are allowed.
  • Unable to find a release with the tag undefined. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 1.0.1. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Jan 16, 2025
@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 16, 2025
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, ready for additional review by human.

@ObsidianReviewBot
Copy link
Collaborator

Changes requested by Zachatoo have been made, assigning additional human for additional review

@joethei
Copy link
Collaborator

joethei commented Jan 17, 2025

name: 'Summarize YouTube Video',, name: 'Summarize YouTube Video (With Prompt)',, Watch Video, Key Points, Technical Terms
Use sentence case in UI

api, api
API is always capitalized.

return url.includes('youtube.com/') || url.includes('youtu.be/');
You should add the https:// at the start for both and use startsWith instead of includes, otherwise this check will also be true for https://example.com/youtu.be

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants