Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Confluence Converter #4999

Closed
wants to merge 1 commit into from

Conversation

addozhang
Copy link
Contributor

@addozhang addozhang commented Dec 29, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin:

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't include Obsidian in the plugin description


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Jan 4, 2025

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't include Obsidian in the plugin description
❌ Unable to find a release with the tag 0.1.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Jan 4, 2025

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 0.1.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

1 similar comment
Copy link

github-actions bot commented Jan 4, 2025

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 0.1.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


Warnings:

⚠️ Your repository does not have issues enabled. Users will not be able to report bugs and request features.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@addozhang
Copy link
Contributor Author

❌ Unable to find a release with the tag 0.1.0. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.

tag 0.1.0 created

@addozhang addozhang closed this Jan 4, 2025
@addozhang addozhang reopened this Jan 4, 2025
@github-actions github-actions bot changed the title add plugin confluence-converter Add plugin: Confluence Converter Jan 4, 2025
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:


Optional

[1]:Casting to any should be avoided as much as possible.


Do NOT open a new PR for re-validation.

@ObsidianReviewBot ObsidianReviewBot removed their assignment Jan 4, 2025
@addozhang
Copy link
Contributor Author

The casting issue was fixed.

@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, ready for manual review.

@joethei
Copy link
Collaborator

joethei commented Jan 13, 2025

# Obsidian Confluence Toolkit Plugin
Naming something "Obsidian xyz" is reserved for first party products we create, please change this header.

This project is licensed under the MIT License.
You need to copy the license text into this file.

"description": "An plugin for converting markdown to Confluence wiki markup.",
Avoid including sentences like "This is a plugin that does ..." in your description, it should be a given since this is only shown when browsing plugins through the app or on our website.
We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple.

name: 'Convert to Confluence and Copy to Clipboard',, .setName("CodeBlock Theme"), .setName("Show Line Numbers"), .setName("Collapse Code Block")
Use sentence case in UI

console.log("parsed tokens",tokens)
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

containerEl.createEl("h1", {text: "Confluence Converter Settings"});
Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.

@joethei joethei self-assigned this Jan 13, 2025
@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Jan 13, 2025
@addozhang
Copy link
Contributor Author

@joethei Thanks for your advice. I have updated following your comments. Please take a review again.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Jan 13, 2025
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Expected ',' or ']' after array element in JSON at position 541990


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: t5k6/obsidian-koreader-highlights. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ The newly added entry is not at the end, or you are submitting on someone else's behalf. The last plugin in the list is: t5k6/obsidian-koreader-highlights. If you are submitting from a GitHub org, you need to be a public member of the org.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants