Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Qbstamp #4701

Closed
wants to merge 2 commits into from
Closed

Add plugin: Qbstamp #4701

wants to merge 2 commits into from

Conversation

Telehakke
Copy link
Contributor

@Telehakke Telehakke commented Nov 16, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/Telehakke/qbstamp

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add Obstamp plugin Add plugin: Obstamp Nov 16, 2024
@ObsidianReviewBot
Copy link
Collaborator

The automated review has not found any issues with your code, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Nov 19, 2024

"id": "obstamp",
Please rename your plugin, the name should not include "Obsidian" or shorthand version of "Obsidian"

private handleMouseMove = (event: MouseEvent): void => {, this.app.workspace.containerEl.removeEventListener(, this.app.workspace.containerEl.addEventListener(, protected showFavoritesMenu = (editor: Editor): void => {
This is a very bad way to do this, for the editor-menu event you already have the existing menu, just append to that.
For the command you should show a suggest modal instead of opening a context menu in a potentially unexpected place, as the mouse does not have to be anywhere near the selected text if one triggers the command.
https://docs.obsidian.md/Plugins/User+interface/Modals#Select+from+list+of+suggestions>

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Nov 19, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Plugin ID mismatch, the ID in this PR (obstamp) is not the same as the one in your repo (qbstamp). If you just changed your plugin ID, remember to change it in the manifest.json in your repo and your latest GitHub release.
❌ Plugin name mismatch, the name in this PR (Obstamp) is not the same as the one in your repo (Qbstamp). If you just changed your plugin name, remember to change it in the manifest.json in your repo and your latest GitHub release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@Telehakke Telehakke changed the title Add plugin: Obstamp Add plugin: Qbstamp Nov 20, 2024
@Telehakke Telehakke closed this Nov 20, 2024
@Telehakke Telehakke reopened this Nov 20, 2024
@Telehakke Telehakke closed this Nov 20, 2024
@Telehakke Telehakke reopened this Nov 20, 2024
@Telehakke Telehakke closed this Nov 21, 2024
@Telehakke Telehakke reopened this Nov 21, 2024
@Telehakke
Copy link
Contributor Author

I edited the PR to change the id and name of the plugin.
Then I get a “fatal: couldn't find remote ref” error in the middle of running actions/checkout@v4.
I do not know how to solve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes requested Minor changes requested PR can be merged after some final changes have been requested plugin Validation failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants