Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: Emoji Picker #4640

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add plugin: Emoji Picker #4640

wants to merge 8 commits into from

Conversation

alifa98
Copy link

@alifa98 alifa98 commented Nov 9, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin:
https://github.com/alifa98/obsidian-emoji-picker

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

Copy link

github-actions bot commented Nov 9, 2024

Hello!

I found the following issues in your plugin submission

Errors:

❌ Please don't include Obsidian in the plugin description
❌ The authorUrl field in your manifest should not point to the GitHub repository of the plugin.
❌ Unable to find a release with the tag 1.1.1. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Nov 9, 2024

Hello!

I found the following issues in your plugin submission

Errors:

❌ The authorUrl field in your manifest should not point to the GitHub repository of the plugin.
❌ Unable to find a release with the tag 1.1.2. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Nov 9, 2024

Hello!

I found the following issues in your plugin submission

Errors:

❌ Could not parse community-plugins.json, invalid JSON. Unexpected token ']', ..."icker"
},
]

" is not valid JSON


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

github-actions bot commented Nov 9, 2024

Hello!

I found the following issues in your plugin submission

Errors:

❌ Your latest Release is missing the main.js file.
❌ Your latest Release is missing the manifest.json file.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@github-actions github-actions bot changed the title Add emoji-picker Plugin Add plugin: Emoji Picker Nov 9, 2024
@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1]:The command name should not include the plugin name.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Nov 10, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made Ready for review and removed Ready for review Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Nov 10, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Nov 10, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Nov 15, 2024

What sets your plugin apart from the other emoji picker plugins?
Or the core features of the operating system?
Please include this information in the README.

"fundingUrl": "https://github.com/alifa98/obsidian-emoji-picker/",
This is meant for links to services like Buy me a coffee, GitHub sponsors and so on, if you don't have such a link remove this line.

if (this.settings.showEmojiButton) {, showEmojiButton: boolean;, new Setting(containerEl)
As of v1.1.0 of Obsidian, the ribbon can be customized within Obsidian. So users can choose what items to include and in what order all in one place. Because of this, we're recommending that new plugins avoid introducing their own toggles for ribbon items.

'Open Emoji Picker', name: 'Select and Insert Emoji',
Use sentence case in UI

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Nov 15, 2024
@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Changes requested Minor changes requested PR can be merged after some final changes have been requested labels Nov 27, 2024
@alifa98
Copy link
Author

alifa98 commented Nov 27, 2024

Hi,

Done!
Thank you very much.

Regards,
Ali

@joethei
Copy link
Collaborator

joethei commented Nov 28, 2024

You have not answered my second question in the README.

Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants