Merge pull request #3114 from obsidian-tasks-group/fix-collapse-statu…

…s-settings fix: Restore 'collapsed' state of Status setting sections
obsidian-tasks-group · Oct 10, 2024 · 4bfeb45 · 4bfeb45
2 parents ab669d1 + 508c5f9
commit 4bfeb45
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/Config/SettingsTab.ts b/src/Config/SettingsTab.ts
@@ -155,7 +155,9 @@ export class SettingsTab extends PluginSettingTab {
         const { headingOpened } = getSettings();
 
         settingsJson.forEach((heading) => {
-            this.addOneSettingsBlock(containerEl, heading, headingOpened);
+            const initiallyOpen = headingOpened[heading.text] ?? true;
+            const detailsContainer = this.addOneSettingsBlock(containerEl, heading, headingOpened);
+            detailsContainer.open = initiallyOpen;
         });
 
         // ---------------------------------------------------------------------------
@@ -379,7 +381,11 @@ export class SettingsTab extends PluginSettingTab {
             });
     }
 
-    private addOneSettingsBlock(containerEl: HTMLElement, heading: any, headingOpened: HeadingState) {
+    private addOneSettingsBlock(
+        containerEl: HTMLElement,
+        heading: any,
+        headingOpened: HeadingState,
+    ): HTMLDetailsElement {
         const detailsContainer = containerEl.createEl('details', {
             cls: 'tasks-nested-settings',
             attr: {
@@ -488,6 +494,8 @@ export class SettingsTab extends PluginSettingTab {
                 }
             }
         });
+
+        return detailsContainer;
     }
 
     private static parseCommaSeparatedFolders(input: string): string[] {