Add LineAwesome #1019
Add LineAwesome #1019
Conversation
edeckers
force-pushed
the
elydeckers/feature/add-line-awesome
branch
from
bd2ba6a to
1a59664
Compare
There was a problem hiding this comment.
LGTM, @hampustagerud could you please take a look as well?
Thanks!
|
LGTM 🙂 |
|
This PR was approved 3 months ago, what are your plans on merging it? |
edeckers
force-pushed
the
elydeckers/feature/add-line-awesome
branch
from
1a59664 to
559fe20
Compare
|
@catalinmiron, @hampustagerud you approved this PR almost a year ago. Today I rebased it on the most recent |
edeckers
force-pushed
the
elydeckers/feature/add-line-awesome
branch
from
559fe20 to
a8a4062
Compare
edeckers
force-pushed
the
elydeckers/feature/add-line-awesome
branch
3 times, most recently
from
b1a4479 to
57e8fd0
Compare
|
@oblador Tonight I rebased this branch on |
|
@oblador we really need this, LineAwesome icons look so great! Is there a chance this PR could be merged? |
edeckers
force-pushed
the
elydeckers/feature/add-line-awesome
branch
from
57e8fd0 to
4e40ba3
Compare
|
I just rebased this branch to make it easier to merge. If there is anything I can do to help, let me know! |
|
@edeckers @hampustagerud we're still needing someone with write access. Is there a chance we could find someone? 😄 |
|
@catalinmiron @hampustagerud @oblador Hey guys! Is there anything we could do for this PR to be merged? 😭 |
|
@oblador @catalinmiron @hampustagerud sorry for being a little bit noisy, but we really want this PR. |
|
@egorshulga you can also integrate a custom icon font using this library. Please refer to https://github.com/oblador/react-native-vector-icons#custom-fonts also let me know if you need any help with it. Adding LineAwesome will also increase the package/bundle size. |
|
@catalinmiron Yeah, I tried, the main issue was that it is hard to include .ttf file into project (as far as I understand this would requrie some gradle scripting, but I am not sure). As this library provides its own framework of including fonts, it would be much easier just to include it into distribution package. As far as I know, even with this library fonts are to be included manually, so the size of the package does not directly influence the size of the resulting app (it is still under developers control). Anyway, I despaired to get line-awesome icons with this library, so I went into googling and found another library, which provides line-awesome icons for RN. It uses different approach (drawing via svg), but it worked, and as I was desperate to get line-awesome in my project ( Still, I believe someday this PR would be dealt with (a year and a half of hanging in the nothingness!), so I would switch back to it. |
|
@edeckers Thanks for originally opening this. I'm closing this as it will need to be rewritten since we have moved to a new package-per-font approach and build process. If anyone is interested in including LineAwesome, please open a feature request, and we can explore it. Note: I'd be hesitant to proceed unless there is significant demand, given that the upstream project hasn't changed in 2 years. |
This PR adds the LineAwesome font to the package