Update js such that if replacement add to cart button is missing, leave existing button #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n is undefined, do not replace button This problem occurred on "awesome" theme - but in general, do not replace perfectly functional button with blank variable. Now makes a check agains empty variable for add to cart button and stock status before replacing with garbage. Tested and working - no change to behaviour if variable is loaded correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that "add-to-box" is about to be replaced with undefined, just leave it - replacing button with undefined variable removes add to cart button, rendering site useless to customer.
This problem occurred on "awesome" theme - but in general, do not replace perfectly functional button with blank variable. Now makes a check that variable is defined for add to cart button and stock status before replacing existing content. Tested and working - no change to behaviour if variable is loaded correctly.