-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge custom translations into client app i18n #592
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there an "Apply" action?
The intention is that user can apply several changes and apply those changes after - not to save change after every single little modifications. |
Is it saved or not? If yes there is nothing to apply. |
User makes some changes that are not saved but can do a batch of them and then apply the changes that will save into the DB. |
I cannot reproduce, maybe I am missing an initial state? Did you start from a clean install or yo had some translations? Also, was this running from 8081 or 9000? |
Was able to reproduce on a clean install... will fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to insist but UX is still not right:
- Single table, one column for the key and one column per language and remove these language tabs
- Update config on dialog's save or remove to; no need for this Apply thing
Please keep things simple.
No description provided.