Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new user attributes UI #587

Merged
merged 1 commit into from
Jan 12, 2025
Merged

feat: new user attributes UI #587

merged 1 commit into from
Jan 12, 2025

Conversation

kazoompa
Copy link
Member

@kazoompa kazoompa commented Jan 12, 2025 •
edited by ymarcon
Loading

TODOs:

  • Render user attrs in User dialog

NOTEs:

  • Prevent duplicates (same name)
  • Remove values (comma separated) of type <> STRING (see DTO)

@ymarcon ymarcon changed the title Added User attributes feat: new user attributes UI Jan 12, 2025
@ymarcon
Copy link
Member

ymarcon commented Jan 12, 2025

Attributes in signup and user profile page is already done, because these are ftl template pages.

@ymarcon ymarcon merged commit 8c88aba into master Jan 12, 2025
2 checks passed
@ymarcon ymarcon deleted the feature/user-attributes branch January 12, 2025 07:58
@ymarcon
Copy link
Member

ymarcon commented Jan 12, 2025

And translations are done in properties, system translation ui is not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazoompa @ymarcon