Skip to content

refactor: improve event methods typing #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radeqq007 merged 1 commit into from
Jun 23, 2026
Merged

refactor: improve event methods typing #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions src/wrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,36 +582,45 @@ export class ElementWrapper<T extends HTMLElement = HTMLElement> {
return this;
}

on<K extends keyof HTMLElementEventMap>(
event: K,
callback: (this: T, ev: HTMLElementEventMap[K]) => void,
): this;
on(event: string, callback: (this: T, ev: Event) => void): this;
/**
* Add an event listener to all elements.
*/
on<K extends keyof HTMLElementEventMap>(
event: K,
callback: (this: HTMLElement, ev: HTMLElementEventMap[K]) => void,
): this {
on(event: string, callback: (this: T, ev: Event) => void): this {
for (const el of this.elements) {
el.addEventListener(event, callback as EventListener);
}
return this;
}

off<K extends keyof HTMLElementEventMap>(
event: K,
callback: (this: T, ev: HTMLElementEventMap[K]) => void,
): this;
off(event: string, callback: (this: T, ev: Event) => void): this;
/**
* Remove an event listener from all elements.
*/
off<K extends keyof HTMLElementEventMap>(event: K, callback: EventListener) {
off(event: string, callback: (this: T, ev: Event) => void): this {
for (const el of this.elements) {
el.removeEventListener(event, callback);
}
return this;
}

once<K extends keyof HTMLElementEventMap>(
event: K,
callback: (this: T, ev: HTMLElementEventMap[K]) => void,
): this;
once(event: string, callback: (this: T, ev: Event) => void): this;
/**
* Add event listener that fires once, then removes itself.
*/
once<K extends keyof HTMLElementEventMap>(
event: K,
callback: (this: HTMLElement, ev: HTMLElementEventMap[K]) => void,
): this {
once(event: string, callback: (this: T, ev: Event) => void): this {
for (const el of this.elements) {
el.addEventListener(event, callback as EventListener, { once: true });
}
Expand Down