You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the PR. The CI failure is weird, especially because it seems to be related to a test you haven't modified. I'll check out what is happening here.
Alright, I figured out the issue. HiveMQ responds with a DISCONNECT on keep alive timeout which leads to an MqttError::Disconnect followed by MqttError::RecoveryRequired's. This leads to the break pattern in the test never matching. Additionally, the tokio::timeout never fires either because the loop turns into a hot loop not reaching a single await point once this error has occured. Mosquitto just closes the connection so an MqttError::Network is returned. The other tests already check for both conditions not sure why just this one didn't.
Do you want to fix this or should I? In the latter case, I'd add this to the changelog etc. as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #110