Skip to content

feat: add skill editing and human confirmation (Issue #40) #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derrickCcc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add skill editing and human confirmation (Issue #40) #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions dashboard/src/lib/ctxClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,16 @@ import type {
RetrieveRequest,
RetrieveResponse,
SeedResponse,
SkillConfirmRequest,
SkillConfirmResponse,
SkillContextRequest,
SkillContextResponse,
SkillMdRequest,
SkillMdResponse,
SkillToolsRequest,
SkillToolsResponse,
SkillUpdateRequest,
SkillUpdateResponse,
StatusIdResponse,
UpstreamRequest,
UpstreamResponse,
Expand Down Expand Up @@ -187,6 +191,9 @@ export const ctx = {
skillTools: (req: SkillToolsRequest) => post<SkillToolsResponse>("/skill_tools", req),
skillContext: (req: SkillContextRequest) => post<SkillContextResponse>("/skill_context", req),
skillMd: (req: SkillMdRequest) => post<SkillMdResponse>("/skill_md", req),
updateSkill: (req: SkillUpdateRequest) => put<SkillUpdateResponse>("/skill", req),
confirmSkill: (req: SkillConfirmRequest) =>
post<SkillConfirmResponse>("/skill/confirm", req),
envVault: {
items: () => get<EnvVaultItemsResponse>("/env-vault/items"),
upsert: (req: EnvVaultUpsertRequest) =>
Expand Down
48 changes: 48 additions & 0 deletions dashboard/src/lib/i18n.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,22 @@ const zh: Dict = {
"skills.detail.confidence": "置信度",
"skills.detail.source": "来源",
"skills.detail.createdAt": "创建时间",
"skills.detail.edit": "编辑",
"skills.detail.save": "保存",
"skills.detail.cancel": "取消",
"skills.detail.confirm": "确认",
"skills.detail.confirmed": "已确认",
"skills.detail.status": "状态",
"skills.detail.name": "名称",
"skills.detail.tags": "标签",
"skills.detail.tagsHint": "逗号分隔",
"skills.detail.parametersHint": "JSON 格式",
"skills.detail.parametersInvalid": "参数不是合法 JSON",
"skills.detail.saveError": "保存失败",
"skills.detail.confirmError": "确认失败",
"skills.status.auto": "自动生成",
"skills.status.edited": "已编辑",
"skills.status.confirmed": "已确认",

// env vault
"envVault.vault.title": "环境变量保险箱",
Expand Down Expand Up @@ -654,6 +670,22 @@ const en: Dict = {
"skills.detail.confidence": "Confidence",
"skills.detail.source": "Source",
"skills.detail.createdAt": "Created at",
"skills.detail.edit": "Edit",
"skills.detail.save": "Save",
"skills.detail.cancel": "Cancel",
"skills.detail.confirm": "Confirm",
"skills.detail.confirmed": "Confirmed",
"skills.detail.status": "Status",
"skills.detail.name": "Name",
"skills.detail.tags": "Tags",
"skills.detail.tagsHint": "Comma separated",
"skills.detail.parametersHint": "JSON format",
"skills.detail.parametersInvalid": "Parameters is not valid JSON",
"skills.detail.saveError": "Save failed",
"skills.detail.confirmError": "Confirm failed",
"skills.status.auto": "Auto-generated",
"skills.status.edited": "Edited",
"skills.status.confirmed": "Confirmed",

"envVault.vault.title": "Env Vault",
"envVault.vault.desc": "Reusable KEY=value records, stored encrypted on disk (fixed app-level key, no passphrase).",
Expand Down Expand Up @@ -1012,6 +1044,22 @@ const ja: Dict = {
"skills.detail.confidence": "信頼度",
"skills.detail.source": "ソース",
"skills.detail.createdAt": "作成日時",
"skills.detail.edit": "編集",
"skills.detail.save": "保存",
"skills.detail.cancel": "キャンセル",
"skills.detail.confirm": "確認",
"skills.detail.confirmed": "確認済み",
"skills.detail.status": "ステータス",
"skills.detail.name": "名称",
"skills.detail.tags": "タグ",
"skills.detail.tagsHint": "カンマ区切り",
"skills.detail.parametersHint": "JSON形式",
"skills.detail.parametersInvalid": "パラメータが有効なJSONではありません",
"skills.detail.saveError": "保存に失敗しました",
"skills.detail.confirmError": "確認に失敗しました",
"skills.status.auto": "自動生成",
"skills.status.edited": "編集済み",
"skills.status.confirmed": "確認済み",

"envVault.vault.title": "環境変数ボールト",
"envVault.vault.desc": "再利用可能な KEY=value レコードを、暗号化してローカル保存します（アプリ固定キー、パスフレーズ不要）。",
Expand Down
29 changes: 29 additions & 0 deletions dashboard/src/lib/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,6 +489,35 @@ export interface SkillMdResponse {
skills: SkillMdItem[];
}

// --- Skill editing & confirmation (Issue #40) ---

export type SkillStatus = "auto-generated" | "edited" | "confirmed";

export interface SkillUpdateRequest {
scope: string;
item_id: string;
name?: string;
description?: string;
body?: string;
parameters?: Record<string, unknown>;
tags?: string[];
}

export interface SkillConfirmRequest {
scope: string;
item_id: string;
}

export interface SkillUpdateResponse {
item: ContextItem;
status: SkillStatus;
}

export interface SkillConfirmResponse {
item: ContextItem;
status: "confirmed";
}

// --- Env Vault ---

export interface EnvVaultItem {
Expand Down
Loading