Skip to content

feat: add skill editing and human confirmation (#40) - #101

Open
Whitehira wants to merge 1 commit into
ob-labs:mainfrom
Whitehira:feat/skill-edit-confirm
Open

feat: add skill editing and human confirmation (#40)#101
Whitehira wants to merge 1 commit into
ob-labs:mainfrom
Whitehira:feat/skill-edit-confirm

Conversation

@Whitehira

Copy link
Copy Markdown

Summary

Closes #40

Changes

Backend (Python)

  • Added POST /update endpoint in server.py with UpdateRequest model
  • Reads existing item, updates content fields (name, description, body, parameters, tags), writes back
  • When confirm: true, sets provenance.confidence = 1.0 and verified = true

Frontend (TypeScript/React)

  • Added UpdateRequest / UpdateResponse types in types.ts
  • Added ctx.update() method in ctxClient.ts
  • Complete edit mode in SkillDetailDialog:
    • ?? Editable fields: name, description, body, parameters (JSON textarea with validation), tags
    • ? Human confirmation button (sets 100% confidence)
    • ??? State badges: auto-generated (blue) / edited (yellow) / confirmed (green)
    • ?? Visual distinction: yellow ring border on edited-but-unconfirmed skills
    • ? Error/success messages for save and confirmation failures
    • ?? Auto-refresh after save/confirm
  • Three-language i18n (zh/en/ja)

Acceptance Criteria

  • A user can open a skill from the Skills page and enter edit mode
  • A user can edit the skill name, description, body, parameters, and tags
  • Edited content persists after page refresh
  • A user can manually confirm a skill
  • Confirmed skills display 100% confidence
  • The UI distinguishes auto-generated, edited, and confirmed states
  • Save or confirmation failures show clear error messages

Files changed

File Changes
src/contextseek/http/server.py +84 lines
dashboard/src/lib/types.ts +18 lines
dashboard/src/lib/ctxClient.ts +3 lines
dashboard/src/lib/i18n.tsx +48 lines
dashboard/src/panels/SkillsPanel.tsx +410/-51 lines

- Add POST /update endpoint to backend for updating skill content
- Add UpdateRequest/UpdateResponse types and ctx.update() client method
- Add edit mode to SkillDetailDialog with editable fields:
  name, description, body, parameters (JSON), tags
- Add human confirmation action (sets provenance.confidence=1.0)
- Add skill state badges: auto-generated / edited / confirmed
- Add visual distinction (yellow ring) for edited-but-unconfirmed skills
- Add error/success messages for save and confirmation failures
- Add i18n keys for zh/en/ja
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add skill editing and human confirmation

1 participant