Bug: Custom Claims fail to propagate #54
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create a custom user type in order to add new claims; it is in the test package space in order to be external to mimic how users would need to do this - Add a test to the session using the custom user type and check for the new claim NOTE: This presently fails.
fredlb
reviewed
Mar 18, 2025
| return json.Marshal(info) | ||
| } | ||
|
|
||
| func (ctu *CustomTestUser) Claim(scope []string, claims *mockoidc.IDTokenClaims) (jwt.Claims, error) { |
There was a problem hiding this comment.
Claims not Claim, and then this works :)
There was a problem hiding this comment.
@fredlb thanks - I applied the change and confirm it that the tests now pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This presently fails as noted in #53
NOTE: Made this a draft PR since the code currently fails a
go test ./...run due to the changes.