Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splash screen for linux modification #2557

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Splash screen for linux modification #2557

wants to merge 2 commits into from

Conversation

Fireronin
Copy link
Contributor

@Fireronin Fireronin commented May 14, 2024 •
edited
Loading

Change summary

Documentation tells user how to change splash screen on linux, o3de/o3de#17913 it currently waits for this pr to be pulled

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
    Umm, I think
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
    Yes
  • Consistency - Does the content consistently follow the Style Guide?
    Yes
  • Help the user - Does the documentation show the user something meaningful?
    Yes, it shows the user how to modify splash screen on linux

Fireronin added 2 commits May 14, 2024 13:09
@Fireronin
Splash screen for linux modification
a26d4f0 
Signed-off-by: Krzysztof Rymski <[email protected]>
@Fireronin
updated documentation
85a4edc 
Signed-off-by: Krzysztof Rymski <[email protected]>
@Fireronin Fireronin marked this pull request as ready for review June 17, 2024 08:52
@Fireronin Fireronin requested a review from a team as a code owner June 17, 2024 08:52
@Fireronin Fireronin mentioned this pull request Jun 17, 2024
Open
@ShaunaGordon
Copy link
Contributor

Change looks good, but is currently awaiting its accompanying engine change to be merged.

@michalpelka
Copy link
Contributor

I will accept change after stabilziaiton branch for doc will be created.

@ShaunaGordon ShaunaGordon added pr-ready-to-merge Indicates that a PR is ready to be merged. status/blocked Issues or PRs that are blocked by other issues or PRs. labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaunaGordon ShaunaGordon ShaunaGordon approved these changes

Assignees
No one assigned
Labels
pr-ready-to-merge Indicates that a PR is ready to be merged. status/blocked Issues or PRs that are blocked by other issues or PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fireronin @ShaunaGordon @michalpelka