Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Python ROS 2 Smoke test. #835

Open
wants to merge 1 commit into
base: point-release/24092
Choose a base branch
from

Conversation

michalpelka
Copy link
Contributor

What does this PR do?

This not-currently-used test was preventing from build with SDK. I am opting on removal it from release.

This problem was detected during review of #832. This commit should be cherry-picked to 832.

How was this PR tested?

Build and run ROS 2 templates against SDK built from source at Ubuntu 22.04 / ROS Humble.

@michalpelka michalpelka marked this pull request as ready for review February 24, 2025 14:26
@michalpelka michalpelka requested review from a team as code owners February 24, 2025 14:26
@michalpelka
Copy link
Contributor Author

After review it should be cherry-picked to #832

@byrcolin byrcolin added the sig/simulation Categorizes an issue or PR as relevant to SIG Simulation label Feb 25, 2025
This test is not working,but prevent project generation with SDK.

Signed-off-by: Michał Pełka <[email protected]>
@michalpelka michalpelka force-pushed the mp/25092_remove_dead_test branch from 4513b86 to 8c0c3e2 Compare February 25, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/simulation Categorizes an issue or PR as relevant to SIG Simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants