Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Meja] 4.08 support #329

Merged
merged 4 commits into from
Jul 22, 2019
Merged

[Meja] 4.08 support #329

merged 4 commits into from
Jul 22, 2019

Conversation

mrmr1993
Copy link
Member

This PR

  • creates separate files for the code that depends on specific OCaml versions
  • uses dune to chose the appropriate file based on the OCaml version
  • makes a few tweaks so that the code works as expected

The only thing left to do before we can shift to 4.08.0 is to find a fix for ocaml-ppx/ppx_tools#77.

@mrmr1993 mrmr1993 requested a review from psteckler July 22, 2019 17:28
@mrmr1993 mrmr1993 merged commit 8080252 into master Jul 22, 2019
@mrmr1993 mrmr1993 deleted the meja/4.08 branch July 22, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteckler psteckler psteckler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrmr1993 @psteckler