Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: check that Cargo.toml is ordered alphabetically #2962

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dannywillems
Copy link
Member

Only for convenience.

@dannywillems dannywillems requested a review from martyall January 23, 2025 16:22
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.79%. Comparing base (70732bc) to head (191146b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2962   +/-   ##
=======================================
  Coverage   76.79%   76.79%           
=======================================
  Files         258      258           
  Lines       61166    61166           
=======================================
  Hits        46971    46971           
  Misses      14195    14195           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martyall
Copy link
Contributor

martyall commented Jan 24, 2025

Nice, makes sense. It seems like we should add this to make format so that we don't ever have to do fix this manually. Also it seems like this could be part of the run_formatting job instead of it's own workflow?

I would have the same comment for all of #2963 #2964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants